-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor template resolution into separate binding and template funcs. #226
Conversation
pkg/sink/sink.go
Outdated
result <- http.StatusAccepted | ||
return | ||
} | ||
r.Logger.Info("params: %+v", params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other log statements in this go func are all log.
while this is r.Logger.
. Is that on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Fixed.
ecf2609
to
75319c9
Compare
* Renames Resolve[d]Binding -> ResolvedTrigger to better reflect its purpose. * Splits NewResources -> ResolveBinding, ResolveTemplate. * Adds logging of resolved event parameters to sink to resolve tektoncd#195. * Adds annotated logging to sink to record event and trigger identifiers in sink logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
purpose.
in sink logs.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes
n/a