Refactor template resolution into separate binding and template funcs. #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
dibyom
approved these changes
Nov 19, 2019
pkg/sink/sink.go
Outdated
| result <- http.StatusAccepted | ||
| return | ||
| } | ||
| r.Logger.Info("params: %+v", params) |
There was a problem hiding this comment.
The other log statements in this go func are all log. while this is r.Logger.. Is that on purpose?
tekton-robot
added
the
approved
wlynch
force-pushed
the
zap-logging
branch
3 times, most recently
from
ecf2609
to
75319c9
Compare
* Renames Resolve[d]Binding -> ResolvedTrigger to better reflect its purpose. * Splits NewResources -> ResolveBinding, ResolveTemplate. * Adds logging of resolved event parameters to sink to resolve tektoncd#195. * Adds annotated logging to sink to record event and trigger identifiers in sink logs.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
purpose.
in sink logs.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes
n/a